G7: route CI jobs via the public surface, not the forge network
Some checks failed
check / gate (push) Failing after 13s
Some checks failed
check / gate (push) Failing after 13s
The first CI run failed with 'Could not resolve host: gitea' — job containers
live on dind's private network and cannot see the forge network. Two ways out,
and they are not equivalent:
(a) put job containers on the forge network. Easy, one line, and it leaves
untrusted workflow code one DNS name from the forge's Postgres. It quietly
repeals I-5.
(b) send jobs to the PUBLIC forge surface over the tunnel, exactly like any
stranger on the internet.
Took (b). The runner no longer needs the forge network at all, so there is now
NO private route from any CI container to anything — a better posture than this
file started with. Cost is a hairpin through Cloudflare plus its ~100s ceiling
per fetch, which for 0.63 GB of objects across 61 repos and depth=1 checkouts is
nowhere near binding.
Test upgraded to assert the stronger property: no CI container joins the forge
network.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -415,6 +415,19 @@ def test_i05_jobs_cannot_bind_mount_from_the_daemon_host():
|
||||
assert 'docker_host: "-"' in cfg
|
||||
|
||||
|
||||
def test_i05_no_ci_container_can_reach_the_forge_network():
|
||||
"""The first CI run failed with "Could not resolve host: gitea" because job
|
||||
containers sit on dind's private network. The easy fix — putting jobs on the
|
||||
forge network — would have left untrusted workflow code one DNS name from
|
||||
the forge's Postgres. Instead jobs reach the PUBLIC forge surface, so no CI
|
||||
container has a private route to anything."""
|
||||
compose = (ROOT / "deploy" / "runner" / "docker-compose.yml").read_text()
|
||||
active = [ln for ln in compose.splitlines() if ln.strip() and not ln.strip().startswith("#")]
|
||||
joined = "\n".join(active)
|
||||
assert "windy-git_default" not in joined, "I-5: no CI container joins the forge network"
|
||||
assert "https://app.windygit.com" in joined
|
||||
|
||||
|
||||
def test_i05_runner_is_a_separate_compose_project_from_the_forge():
|
||||
"""Runners restart, crash, get starved and get killed. None of that should
|
||||
ever touch the thing serving repositories."""
|
||||
|
||||
Reference in New Issue
Block a user