auth: G3.2 hub JWKS verifier — humans can sign in to the plane (SSO #14)
The human path refused every token in production (503 human_signin_not_ready) because no verifier existed. api/app/hub_jwt.py verifies hub access tokens against account.windyword.ai's JWKS: - RS256 only (closes alg:none and HS256-with-public-key confusion) - iss must be "windy-identity" — what hub ACCESS tokens carry (observed live); id_tokens (discovery-URL issuer) are not accepted as bearers - aud optional today, must name Windy Git when present; hub_require_aud flips it mandatory once the hub emits it. PyJWT's own aud check is off on purpose: it rejects ANY aud-bearing token when no audience is given. - type must be human; identity = windy_identity_id, never sub (per-row id) - production verifies even if require_verified_jwt is off 11 behavioral tests sign real RS256 tokens with a local key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
129
api/app/hub_jwt.py
Normal file
129
api/app/hub_jwt.py
Normal file
@@ -0,0 +1,129 @@
|
||||
"""Human token verification (G3.2) — hub access tokens from account.windyword.ai.
|
||||
|
||||
Until this existed the human path refused every token in production (503
|
||||
`human_signin_not_ready`), because reading an unverified JWT's claims is an
|
||||
authentication bypass, not a shortcut. This module is what lets it say yes.
|
||||
|
||||
The token it accepts is the hub's ACCESS token, as observed live 2026-09-23:
|
||||
|
||||
header {alg: RS256, typ: JWT, kid: <published at /.well-known/jwks.json>}
|
||||
claims iss = "windy-identity" ← NOT the discovery doc's issuer URL
|
||||
type = "human", exp - iat = 900 s
|
||||
sub = per-row user id ← NOT the cross-product identity
|
||||
windy_identity_id = the Windy Account UUID (what Gitea's OIDC links on)
|
||||
no `aud` yet
|
||||
|
||||
What it refuses, by construction:
|
||||
|
||||
* **Anything but RS256.** One algorithm, never a list. Closes `alg: none` and
|
||||
HS256-with-the-public-key confusion.
|
||||
* **An unknown `kid`**, a wrong issuer, an expired token — library-checked.
|
||||
* **An id_token used as a bearer.** id_tokens carry iss = the discovery URL and
|
||||
aud = some relying party; they prove a login happened to *someone else's*
|
||||
client, not that this caller may act here.
|
||||
* **A non-human `type`.** An agent's authority comes from its EPT and a live
|
||||
Eternitas lookup, never from a hub token dressed as a person.
|
||||
* **A token with no `windy_identity_id`.** `sub` is a different namespace (the
|
||||
per-row user id); falling back to it would silently mint identities that
|
||||
match nothing Gitea knows.
|
||||
|
||||
`aud` (SSO matrix, lane 8c): the hub will start emitting it once every
|
||||
consumer is ready. Today it is optional; when present it MUST name Windy Git.
|
||||
`hub_require_aud=True` makes it mandatory — flip it once the hub emits it.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from dataclasses import dataclass
|
||||
|
||||
import jwt
|
||||
from jwt import PyJWKClient
|
||||
|
||||
ALGORITHMS = ["RS256"] # exactly one. Never widen this list.
|
||||
|
||||
_jwks_client: PyJWKClient | None = None
|
||||
_jwks_url: str | None = None
|
||||
|
||||
|
||||
class HubTokenInvalid(Exception):
|
||||
"""Not a valid, currently-signed hub access token for a human."""
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class VerifiedHuman:
|
||||
identity_id: str
|
||||
email: str | None
|
||||
expires_at: int | None
|
||||
|
||||
|
||||
def _client(base_url: str) -> PyJWKClient:
|
||||
"""Cached JWKS client; refetches on an unknown kid so rotation self-heals."""
|
||||
global _jwks_client, _jwks_url
|
||||
url = f"{base_url.rstrip('/')}/.well-known/jwks.json"
|
||||
if _jwks_client is None or _jwks_url != url:
|
||||
_jwks_client = PyJWKClient(url, cache_keys=True, lifespan=300)
|
||||
_jwks_url = url
|
||||
return _jwks_client
|
||||
|
||||
|
||||
def verify_hub_token(
|
||||
token: str,
|
||||
base_url: str,
|
||||
*,
|
||||
issuers: tuple[str, ...],
|
||||
audiences: tuple[str, ...],
|
||||
require_aud: bool,
|
||||
signing_key=None,
|
||||
) -> VerifiedHuman:
|
||||
"""Verify a hub access token. Raises HubTokenInvalid on ANY doubt.
|
||||
|
||||
`signing_key` exists for tests only (a locally generated key, no network).
|
||||
"""
|
||||
try:
|
||||
key = (
|
||||
signing_key
|
||||
if signing_key is not None
|
||||
else _client(base_url).get_signing_key_from_jwt(token).key
|
||||
)
|
||||
except Exception as exc: # noqa: BLE001 - unknown kid, unreachable JWKS, malformed
|
||||
raise HubTokenInvalid(f"no usable signing key: {type(exc).__name__}: {exc}") from exc
|
||||
|
||||
try:
|
||||
claims = jwt.decode(
|
||||
token,
|
||||
key,
|
||||
algorithms=ALGORITHMS,
|
||||
issuer=list(issuers),
|
||||
options={
|
||||
"require": ["iss", "exp", "iat"],
|
||||
"verify_signature": True,
|
||||
"verify_exp": True,
|
||||
"verify_iss": True,
|
||||
# Checked by hand below: PyJWT rejects any token CARRYING aud
|
||||
# when no audience is passed, which would break the moment the
|
||||
# hub starts emitting it — the exact trap the SSO matrix names.
|
||||
"verify_aud": False,
|
||||
},
|
||||
)
|
||||
except jwt.PyJWTError as exc:
|
||||
raise HubTokenInvalid(f"{type(exc).__name__}: {exc}") from exc
|
||||
|
||||
aud = claims.get("aud")
|
||||
if aud is None:
|
||||
if require_aud:
|
||||
raise HubTokenInvalid("token carries no aud and hub_require_aud is on")
|
||||
else:
|
||||
presented = {aud} if isinstance(aud, str) else set(aud) if isinstance(aud, list) else set()
|
||||
if not presented & set(audiences):
|
||||
raise HubTokenInvalid(f"aud {sorted(presented)} does not name Windy Git")
|
||||
|
||||
if claims.get("type", "human") != "human":
|
||||
raise HubTokenInvalid(f"token type {claims.get('type')!r} is not a human access token")
|
||||
|
||||
identity = claims.get("windy_identity_id") or claims.get("windyIdentityId")
|
||||
if not isinstance(identity, str) or not identity.strip():
|
||||
raise HubTokenInvalid("token carries no windy_identity_id")
|
||||
|
||||
return VerifiedHuman(
|
||||
identity_id=identity, email=claims.get("email"), expires_at=claims.get("exp")
|
||||
)
|
||||
Reference in New Issue
Block a user